On Thu, Sep 07, 2023 at 05:24:35PM +0200, Matthieu Herrb wrote: > On Thu, Sep 07, 2023 at 07:11:40AM +0200, Anton Lindqvist wrote: > > On Wed, Sep 06, 2023 at 05:42:37AM -0600, Robert Nagy wrote: > > > CVSROOT: /cvs > > > Module name: xenocara > > > Changes by: rob...@cvs.openbsd.org 2023/09/06 05:42:37 > > > > > > Modified files: > > > driver/xf86-video-amdgpu/src: amdgpu_present.c drmmode_display.h > > > xserver/glamor : glamor.h glamor_egl.c > > > > > > Log message: > > > unbreak build with clang-16 by fixing up function definitions to match > > > > > > our uint64_t is an unsinged long long, but CARD64 is defined as unsigned > > > long > > > so the function pointer types in both glamor and xf86-video-amdgpu were > > > mismatched and clang-16 treats that as an error > > > > > > ok matthieu@ > > > > This broke the tree. Here's a potential fix. > > Hmm no, this one reverts parts of the llvm 16 diffs. > > What about this that gets rid of CARD64 completely in this context ? > > hint for the X developpers: CARD64 and friends are normally reserved > for the X protocol specification and implementation > > All other uses as cheap substites for uint64_t or similar are just > historical artefacts from an era where there was no standard integer > types with known fixed lengths.
ok anton@ fwiw
