CVSROOT: /cvs
Module name: src
Changes by: m...@cvs.openbsd.org 2024/04/30 11:04:23
Modified files:
sys/nfs : nfs_serv.c nfs_socket.c nfs_subs.c nfs_var.h
nfs_vfsops.c nfs_vnops.c nfsm_subs.h nfsnode.h
Log message:
Convert all the NFS macros (in nfsm_subs.h) into inline functions with the
appropriate extra arguments.
This (hopefully) completes the unmessyfication work started by thib@ a long,
long time ago (in a galaxy far away).
The conversion logic has been:
- nfsm_dissect has been turned into an rvalue expression, leaving the
cast operation up to its caller.
- macros which had three different exit paths (return, goto nfsmout or
fallthrough) have been split so that no macros have more than two exit paths.
- then they have been modified to return a value, which lets the caller
figure out what exit path is needed.
- local variables abused by the macros are now local variables of the new
inline functions.
This single commit is the sum of 25 intermediate diffs, which have all been
carefully reviewed by (at least) jsg@ and semarie@.
Tested with v2 and v3 servers and clients.
ok jsg@ semarie@
