CVSROOT: /cvs Module name: src Changes by: t...@cvs.openbsd.org 2024/07/12 02:58:59
Modified files: lib/libcrypto/x509: x509_v3.c Log message: Rewrite X509v3_add_ext() This is another brilliancy straight out of muppet labs. Overeager and misguided sprinkling of NULL checks, going through the trademark poor code review, made this have semantics not matching what almost every other function with this signature would be doing in OpenSSL land. This is a long standing mistake we can't fix without introducing portability traps, but at least annotate it. Simplify the elaborate dance steps and make this resemble actual code. ok jsing