On Thu, 13 Mar 2025 08:06:48 +0100
Anton Lindqvist <an...@basename.se> wrote:
> On Tue, Mar 11, 2025 at 07:44:27PM -0600, YASUOKA Masahiko wrote:
>> CVSROOT: /cvs
>> Module name: src
>> Changes by: yasu...@cvs.openbsd.org 2025/03/11 19:44:27
>>
>> Modified files:
>> sys/netinet : ip_output.c
>>
>> Log message:
>> Fix the problem that skips the various checks for packets for
>> broadcast mistakenly introduced by the revision 1.103 imported from
>> netbsd 24 years ago. Especially, the problem has allowed one to send
>> broadcast packets without the SO_BROADCAST option. Found by IIJ.
>>
>> ok blumn
>
> Seeing a regression in regress/sys/kern/sosplice, the test case
> consistently fail.
>
> This commit looks related. Care to take a look?
>
>> sys/kern/sosplice
> Exit: 1
> Duration: 00:17:17 (-00:00:01)
> Log: 417-sys-kern-sosplice.log
>
> ==== run-bcast ====
> SUDO="doas -n" perl /home/src/regress/sys/kern/sosplice/loop/bcast.pl
> Send to connect socket failed: Permission denied at
> /home/src/regress/sys/kern/sosplice/loop/bcast.pl line 82.
> *** Error 13 in loop (Makefile:51 'run-bcast')
> FAILED
>
Thank you for noticing this. The test case should be fixed.
ok?
Index: regress/sys/kern/sosplice/loop/bcast.pl
===================================================================
RCS file: /var/cvs/openbsd/src/regress/sys/kern/sosplice/loop/bcast.pl,v
retrieving revision 1.1
diff -u -p -r1.1 bcast.pl
--- regress/sys/kern/sosplice/loop/bcast.pl 9 Jan 2021 15:39:37 -0000
1.1
+++ regress/sys/kern/sosplice/loop/bcast.pl 13 Mar 2025 07:36:31 -0000
@@ -59,6 +59,8 @@ my $cs = IO::Socket::IP->new(
Proto => "udp",
Type => SOCK_DGRAM,
) or die "Connect socket failed: $@";
+$cs->setsockopt(SOL_SOCKET, SO_BROADCAST, 1)
+ or die "Set socket option SO_BROACAST failed: $!";
print "connect to host '$host' service '$service'\n" if $verbose;
my $as = $ls;
