On Thu, Oct 11, 2012 at 03:14:32PM -0600, Gilles Chehade wrote:
> CVSROOT:      /cvs
> Module name:  src
> Changes by:   gil...@cvs.openbsd.org  2012/10/11 15:14:32
> 
> Modified files:
>       usr.sbin/smtpd : lka_session.c parse.y ruleset.c smtpd.conf.5 
>                        smtpd.h 
> 
> Log message:
> - replace "from all" and "for all" with "from any" and "for any"
> 
> ok eric@, chl@

I am adding a little comment here because that commit has consequences
which deserve a warning.

One reason for this change is to be consistent with the pf dialect but
also to remove the "all" keyword from the grammar because it masks the
"all" interface group.  As a result, a rule like:

        accept from all ... 

is still accepted by the parser, but the behavior changes: it will not
match mails enqueued through the local socket anymore, only those that
come from any listening interface.

You *really* want to rewrite this as:

        accept from any ...

Reply via email to