On Thu 2013.01.10 at 02:43 +0000, Stuart Henderson wrote: > On 2013/01/01 07:19, Okan Demirmen wrote: > > CVSROOT: /cvs > > Module name: xenocara > > Changes by: o...@cvs.openbsd.org 2013/01/01 07:19:56 > > > > Modified files: > > app/cwm : calmwm.h client.c group.c kbfunc.c xutil.c > > > > Log message: > > make num of groups no longer off-by-one; from Alexander Polakov > > > > note that a re-exec of cwm will not rewrite the group number atom of > > *existing* clients, so they will remain off-by-one until each client has > > its atom updated, or of course a restart of X. > > > > Does this actually fix something, or is it just cosmetic? > It breaks my use of cwm.
doh, and it's only cosmetic - sorry. > Before this commit, when cwm started (and before carrying out any > group operations), newly opened windows would be in group1 / > _NET_WM_DESKTOP(CARDINAL) = 0, the initial root window is > _NET_CURRENT_DESKTOP(CARDINAL) = 0, and when you do 'grouponly2' > followed by 'grouponly1' those same windows are displayed. > > After this commit, we get the same atoms for root/client windows > on the initial display, but 'grouponly2' followed by 'grouponly1' > goes to _NET_CURRENT_DESKTOP(CARDINAL) = 1, and the only way to > re-display the desktop0 windows is to use cyclegroup/rcyclegroup. this should solve it, but I'm not able to test until tomorrow: and if not, I'll revert. Index: group.c =================================================================== RCS file: /home/open/cvs/xenocara/app/cwm/group.c,v retrieving revision 1.68 diff -u -p -r1.68 group.c --- group.c 1 Jan 2013 14:50:01 -0000 1.68 +++ group.c 10 Jan 2013 03:05:19 -0000 @@ -160,7 +160,7 @@ group_init(struct screen_ctx *sc) xu_ewmh_net_showing_desktop(sc); xu_ewmh_net_virtual_roots(sc); - group_setactive(sc, 0); + group_setactive(sc, 1); } void