On Sat, May 04, 2013 at 06:22:14AM -0600, Stuart Henderson wrote: > CVSROOT: /cvs > Module name: src > Changes by: st...@cvs.openbsd.org 2013/05/04 06:22:14 > > Modified files: > sys/dev/usb : uthum.c > > Log message: > - remove unused DPRINTFN, simple DPRINTF is enough > - sc_dying is unused, remove it and the uthum_activate() function
Removing uthum_activate() breaks the detach path: uhidev0 at uhub2 port 1 configuration 1 interface 0 "Ten X Technology, Inc. TEMPer sensor" rev 1.10/1.50 addr 2 uhidev0: iclass 3/1 uthum0 at uhidev0 uhidev1 at uhub2 port 1 configuration 1 interface 1 "Ten X Technology, Inc. TEMPer sensor" rev 1.10/1.50 addr 2 uhidev1: iclass 3/0 uthum1 at uhidev1 uthum1: type ds75/12bit (temperature) panic: config_detach: forced detach of uhidev0 failed (45) Stopped at Debugger+0x4: popl %ebp RUN AT LEAST 'trace' AND 'ps' AND INCLUDE OUTPUT WHEN REPORTING THIS PANIC! IF RUNNING SMP, USE 'mach ddbcpu <#>' AND 'trace' ON OTHER PROCESSORS, TOO. DO NOT EVEN BOTHER REPORTING THIS WITHOUT INCLUDING THAT INFORMATION! ddb{0}> trace Debugger(d09634e6,f5446e88,d0940380,f5446e88,d31ef880) at Debugger+0x4 panic(d0940380,d31ef894,2d,d0822722,d31d1400) at panic+0x5d config_detach(d31ef880,1,d2fde520,d2fde520,d31ef780) at config_detach+0x332 usb_disconnect_port(d2fde520,d2feeb00,10,1,1) at usb_disconnect_port+0x60 uhub_explore(d2feea00,1,20,d0a1a98f,40) at uhub_explore+0x11d usb_explore(d2fee980,20,d0a1a98f,0,d8fdd8b8) at usb_explore+0xcb usb_task_thread(d8fdd8b8) at usb_task_thread+0xb1 Bad frame pointer: 0xd0c3ce28 ddb{0}>