On 2013/11/12 05:45, Ted Unangst wrote: > I think we lost something. This commit should reference the original.
yes, it should.. standard method is to include the original commit message and usually revision as well; if you are pasting in the commit log then do not include the complete --------------------------- lines because it breaks some tools that read logs. so e.g. MFC vnode lock fix, req'd by dcoppa, ok deraadt: -/-------------------------- revision 1.77 date: 2013/10/29 03:11:08; author: guenther; state: Exp; lines: +11 -3; Unlock the vnode while calling a device's d_close routine, except when it's locked for changing the type (i.e., revoke()). We already unlock it while calling the d_open, d_read, and d_write routines and this is safe for the same reason: the device routines operate at a lower level and don't need the protection of the vnode locks. This is important as the device close routine may block indefinitely. "don't see anything wrong" tedu@ -/-------------------------- > On Mon, Nov 11, 2013 at 19:37, William Yodlowsky wrote: > > CVSROOT: /cvs > > Module name: src > > Changes by: will...@cvs.openbsd.org 2013/11/11 19:37:04 > > > > Modified files: > > sys/kern : Tag: OPENBSD_5_4 spec_vnops.c > > > > Log message: > > MFC: > > > > This is > > http://ftp.openbsd.org/pub/OpenBSD/patches/5.4/common/003_vnode.patch > > > > An unprivileged user may hang the system. > > > > requested by dcoppa > > fix by guenther > > ok deraadt
