CVSROOT:        /cvs
Module name:    src
Changes by:     dera...@cvs.openbsd.org 2014/06/01 09:10:53

Modified files:
        lib/libssl/src/crypto/buffer: buffer.c 

Log message:
Commit this before the head-scratching leads to premature baldness:
memset(a->data, 0, (unsigned int)a->max);
but the decl is:
size_t max;
size_t could be larger than int, especially in some of the systems OpenSSL
purports to support.

How do _intentionally truncating_ casts like enter into a codebase?
Lack of understanding of C, at a minimum.  Generally the objects are
small, but this code is _intentionally unready_ for large objects.
ok miod

Reply via email to