Hi Nic,
Nicholas Marriott wrote on Fri, Jan 16, 2015 at 08:37:58AM +0000:
> On Fri, Jan 16, 2015 at 08:35:43AM +0000, Nicholas Marriott wrote:
>> On Thu, Jan 15, 2015 at 06:58:18PM -0700, Ingo Schwarze wrote:
>>> CVSROOT: /cvs
>>> Module name: src
>>> Changes by: schwa...@cvs.openbsd.org 2015/01/15 18:58:18
>>>
>>> Modified files:
>>> share/mk : bsd.man.mk bsd.subdir.mk
>>> lib/libssl/man : Makefile
>>> lib/libcrypto/man: Makefile
>>> usr.bin/mandoc : Makefile
>>>
>>> Log message:
>>> Delete the MANLINT variable and the related SUFFIXES rules because
>>> since yesterday, "mandoc -Tlint -Wfatal" can no longer fail.
>>> Instead, as suggested by deraadt@, provide a manlint target
>>> that is *not* run during make build, but can be run
>>> whenever you want to check syntax of manuals.
>>> "nice stuff" deraadt@
>> I think it would be nice if WARNINGS=yes still made mandoc show
>> warnings, even if it isn't fatal. If I set WARNINGS=yes, I've already
>> said I want warnings, why do I need to run another target?
> Well, to answer myself, mandoc isn't even normally run during build,
> so I suppose it is fair enough to be separate.
I agree. /usr/share/mk/bsd.README says:
WARNINGS Adds appropriate warning flags (defined in CDIAGFLAGS,
e.g., -Wall...) to compiles. [no]
Causing it to run additional compilers (as opposed to just adding
flags to ones that are run anyway) looks like excessive complexity
to me.
Yours,
Ingo
