CVSROOT:        /cvs
Module name:    src
Changes by:     mes...@cvs.openbsd.org  2017/08/11 14:56:15

Modified files:
        sys/net        : pipex.c 

Log message:
During MPPE key reduction on the 40 bits case the first 3 octets need to be
changed with known constants (RFC3079). Current code uses a switch case without
breaks which implicitly makes the code correct, but to improve readibility the
first octect should have the constant assigned also in the first case, without
relying on a fallthrough to the second, and the break statement should be
called on boths cases.

This was a false positive found in Coverity CID 1453390, but changed due to
to readibility as explained above.

After discussion with millert@ and guenther@

Reply via email to