Hmm, I see your point. I was most interested in the pre/post script changes. Would you be happy with a 'last modified' column on the scripts page? CC
________________________________ From: Jan Pazdziora [mailto:[EMAIL PROTECTED] Sent: Fri 9/19/2008 7:29 PM To: Coe, Colin C. (Unix Engineer) Cc: spacewalk-devel@redhat.com Subject: Re: [Spacewalk-devel] Patch: add 'Last Changed' column toKickstart profile list page On Wed, Sep 10, 2008 at 07:01:30AM +0800, Coe, Colin C. (Unix Engineer) wrote: > <<0009-add-a-Last-Changed-column-to-the-Kickstart-Profile.patch>> > Hi all > > Attached is a simple patch to add a 'Last Changed' column in the > Kickstart Profile page. I added this after being away from work for a > couple of weeks and being told some changes where made to some Kickstart > profiles but no-one could tell me which ones had been changed. Colin, I can see that the patch was not committed yet. The problem I can see is that it only takes into account changes in rhnKSData, yet the "kickstart" thing has data changed in multiple tables. So if your peers tell you they changed something while you were gone, if they did change in some of the child tables, you won't see the timestamp changed. I wonder if appart from the modified column we'd want to have something like modified_general, and have triggers in all related tables to also update this value ... -- Jan Pazdziora Satellite Engineering, Red Hat NOTICE: This email and any attachments are confidential. They may contain legally privileged information or copyright material. You must not read, copy, use or disclose them without authorisation. If you are not an intended recipient, please contact us at once by return email and then delete both messages and all attachments. _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
