Ah, originally I'd used results.size and it barfed... CC
> -----Original Message----- > From: Jesus M. Rodriguez [mailto:[EMAIL PROTECTED] > Sent: Sunday, 5 October 2008 10:01 PM > To: Coe, Colin C. (Unix Engineer) > Cc: spacewalk-devel@redhat.com > Subject: Re: [Spacewalk-devel] Patch: set/getCustomOptions Junit test > > Colin, > > Here are some comments on that test. > > 1) instead of looping through the results array to count it, > just do this: > > Object[] results = handler... > assertEquals(5, results.length); > > Everything else looked ok. > > jesus > > On Sun, Oct 5, 2008 at 4:42 AM, Coe, Colin C. (Unix Engineer) > <[EMAIL PROTECTED]> wrote: > > Hi all > > > > Attached is a patch to implement the JUnit tests for the > kickstart.profile.get/setCustomOptions API calls. > > > > Comments/criticisms welcome. > > > > CC > > > > NOTICE: This email and any attachments are confidential. > > They may contain legally privileged information or > > copyright material. You must not read, copy, use or > > disclose them without authorisation. If you are not an > > intended recipient, please contact us at once by return > > email and then delete both messages and all attachments. > > > > _______________________________________________ > > Spacewalk-devel mailing list > > Spacewalk-devel@redhat.com > > https://www.redhat.com/mailman/listinfo/spacewalk-devel > > > NOTICE: This email and any attachments are confidential. They may contain legally privileged information or copyright material. You must not read, copy, use or disclose them without authorisation. If you are not an intended recipient, please contact us at once by return email and then delete both messages and all attachments. _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel