-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hey Jason, not sure if this is an issue but am I correct that you
changed the incoming key the API expects from first_names to first_name?

If so that might need a follow up, in general we try not to change the
API signatures so as not to break any pre-existing user/customer
scripts.

If we get in a situation where we really want to, we mark the old
way deprecated in the XMLRPC and then return both. (or in your case
accept both) Then after some period of time we can remove
deprecated things. (I can't remember what was agreed upon, maybe 2
Satellite releases? anybody recall?)

So if I'm reading this right you probably want to change the XML RPC
doc to:

#prop_desc("string", "first_names", "(deprecated)")
#prop("string", "first_name")

And then I guess try for first_name, if not found try first_names, and
if neither found error out. (hopefully it does this already)

Similarly for the getDetails call you'll probably want to mark
deprecated and return a key in the hash for both.

Cheers,

Devan

- -- 
  Devan Goodwin <dgood...@redhat.com>
  Software Engineer     Spacewalk / RHN Satellite
  Halifax, Canada       650.567.9039x79267
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)

iEYEARECAAYFAkmV7wYACgkQAyHWaPV9my61swCfQjhaijjOBlk0qWG56A+Trw9P
DM0AoILpXPtzPp3m2DZyTTVSYG2wwOA4
=Z69T
-----END PGP SIGNATURE-----

_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel

Reply via email to