Did some preliminary analysis and following are the results: Total 64 views/ files have been ported.
Only two files are exactly same. There are 23 files (including the above two) which have less than 10 lines of difference. These differences are mostly either nvl(), decode(), 'show error', or command terminator (/) differences. So these diffrences can be deemed minor and the Oracle version files can also be changed so that they can be put under common/ directory. The other differences might also be minor, despite being large in number of lines in diff. This is because I remember having removed the trailing (commit-message like) comments from some files. So the number of files with minor changes can be a little higher. I am abandoning any efforts in creating a common/ directory for now, in favour of query tagging efforts. Jeff/Devan, please let me know if you wish to prioritize this. Will pick this up again if we are able to finish query tagging in time. Best regards, PS: For future reference, following commands were used for the above analysis (to be executed from schema/spacewalk/): # see the diff ls postgresql/views/ | while read LINE; do echo "***********$LINE**********"; diff rhnsat/views/$LINE postgresql/views/$LINE ; done # see the number of lines of difference for each file ls postgresql/views/ | while read LINE; do echo "***********$LINE**********"; diff rhnsat/views/$LINE postgresql/views/$LINE | wc -l ; done # see if there are any diffs between pairs of files ls postgresql/views/ | while read LINE; do echo "***********$LINE**********"; diff rhnsat/views/$LINE postgresql/views/$LINE 1>/dev/null; echo $? ; done On Mon, Mar 2, 2009 at 1:46 PM, Gurjeet Singh < gurjeet.si...@enterprisedb.com> wrote: > The three pending views have also been ported and pushed to repo. Two of > these have been uncommented from main.sql, and the one that is left in > comments is because it uses rhn_channel package, which hasn't been ported > yet. > > With this, porting of viws is complete. Now as per Jeff's comments on IRC, > I will try to put the unmodififed view files in a common directory, say > schema/spacewalk/postgresql/common/ . > > Best regards, > > PS: There are a few files that were in the rhnsat/views/ directory but not > mentioned on the wiki page. These are: > > rhnChannelFamilyServerPhysical_synonyms.sql > rhnChannelFamilyServerVirtual_synonyms.sql > rhnUserAvailableChannels_grants.sql > > > > On Sun, Feb 22, 2009 at 10:08 AM, Gurjeet Singh < > gurjeet.si...@enterprisedb.com> wrote: > >> Done with almost all the views. Only three views are left for porting. >> Apart from these three, 18 views that have been converted had to be >> commented from the main.sql since these views use either packages or the >> object EVR_T. So started on package migration. >> >> The changes have been pushed to pgsql branch and wiki page has been >> updated. Will be adding a similar page for Package porting. >> >> Best regards, >> >> >> On Wed, Feb 18, 2009 at 9:24 PM, Jeff Ortel <jor...@redhat.com> wrote: >> >>> All, >>> >>> I've added the view migration tracking table ( >>> https://fedorahosted.org/spacewalk/wiki/PgportViews ) and linked to the >>> tasks ( https://fedorahosted.org/spacewalk/wiki/PostgresTasks ) page. >>> This table __is__ ordered according to dependency. >>> >>> -jeff >>> >>> _______________________________________________ >>> Spacewalk-devel mailing list >>> Spacewalk-devel@redhat.com >>> https://www.redhat.com/mailman/listinfo/spacewalk-devel >>> >> >> >> >> -- >> gurjeet[.sin...@enterprisedb.com >> EnterpriseDB http://www.enterprisedb.com >> >> singh.gurj...@{ gmail | hotmail | indiatimes | yahoo }.com >> >> > > > -- > gurjeet[.sin...@enterprisedb.com > EnterpriseDB http://www.enterprisedb.com > > singh.gurj...@{ gmail | hotmail | indiatimes | yahoo }.com > > -- gurjeet[.sin...@enterprisedb.com EnterpriseDB http://www.enterprisedb.com singh.gurj...@{ gmail | hotmail | indiatimes | yahoo }.com
_______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
