On Thu, Mar 12, 2009 at 11:00:06PM -0400, Brandon Perkins wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > > > Jesus M. Rodriguez wrote: > > 2009/3/12 Michael Mraka <michael.mr...@redhat.com>: > >> Jan Pazdziora wrote: > >> % On Thu, Mar 12, 2009 at 07:27:19AM +0100, Jan Pazdziora wrote: > >> % > On Wed, Mar 11, 2009 at 08:09:49PM -0700, Mike McCune wrote: > >> % > > > >> <http://git.fedorahosted.org/git/?p=spacewalk.git;a=commitdiff;h=6c1be4e0cc992afb834e8fedf7c3094746466ba4> > >> % > > > >> % > > 'git pull --rebase' next time? > >> % > > >> % > It should be possible to do a post commit hook to refuse commits > >> % > which introduce merges that have the default commit message (= likely > >> % > not intended merge). > >> % > > >> % > Is this something we might want to try setting up? > >> % > >> % We should also be able to try to enforce the > >> % > >> % ^((\d+)\s-\s)? > >> % > >> % format for bugzilla numbers. > >> > >> I agree with commit hooks. Anyway format bugzilla numbers is more > >> complicated > >> (multiple bz numbers or none). > > > > +1 to the enforcement. Sounds like a good idea. > > > > Agreed with Michael here that the commit message, my regex sucks but > > I'll try to at least describe > > it :) > > > > \d*(,\d*) - msg > > > > so you can have 0 or more bugzilla numbers separated by commas. The > > list of bugzilla > > numbers is set apart from the msg by a space hyphen space, then > > followed by a commit message. > > If there is no bugzilla number there should be no hyphen. > > > > jesus > > > > You just had to bait the perl guys didn't you? ;) I think what you > meant is: > > (\d+(,\d+)*\ \-\ )?.+ > > and as can be seen on my cube wall: http://xkcd.com/208/
HAHAHA very nice. -- jesus m. rodriguez | jes...@redhat.com sr. software engineer | irc: zeus rhn satellite & spacewalk | 919.754.4413 (w) rhce # 805008586930012 | 919.623.0080 (c) +-------------------------------------------+ | "Those who cannot learn from history | | are doomed to repeat it." | | -- George Santayana | +-------------------------------------------+ _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
