Joshua Roys wrote:
Hello all,
Presently we end up with a directory with the init script inside it:
$ rpm -ql tsdb
/etc/rc.d/init.d/tsdb_local_queue
/etc/rc.d/init.d/tsdb_local_queue/init_script
...
Patch attached.
I do not like it.
Neither that bug, nor your patch :)
Yes what you find, is definitely not correct and bug.
But I have few question:
a) why you put there?:
+%if 0%{!?_initddir:1}
+%define _initddir %{_sysconfdir}/rc.d/init.d
+%endif
Is some platform where _initddir is not defined?
b) Why not instead of:
+mkdir -p $RPM_BUILD_ROOT%{_initddir}
...
-install -d $RPM_BUILD_ROOT%{init_script}
install -m 755 LocalQueue/init_script $RPM_BUILD_ROOT%{init_script}
Simplier:
-install -d $RPM_BUILD_ROOT%{init_script}
-install -m 755 LocalQueue/init_script $RPM_BUILD_ROOT%{init_script}
+install -D -m 755 LocalQueue/init_script $RPM_BUILD_ROOT%{init_script}
c) I agree with:
-%define init_script %{_sysconfdir}/rc.d/init.d/tsdb_local_queue
+%define init_script %{_initddir}/tsdb_local_queue
Unless you have some rationale for a), I will put there b) with those
change and c) tomorrow. Of course I will be happier if you create that
new patch :)
--
Miroslav Suchy
Red Hat Satellite Engineering
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
