Hey Silvio, ----- Original Message ----- > On 08/28/2013 07:42 PM, Grant Gainey wrote: > > Fixing the tests to be more explicit and less reliant on "typical setups" > > is, at least in my opinion, always a good thing. > > I am glad to hear that, as at the moment that's exactly what I am doing! > > I attach three patches that go just in that direction.
Pushed as commit 1687c3536eb9c8b312a3e3005335fcbff177a315 Thanks for the contribution! Grant > > 001 - TestUtils: don't assume that tests are run from a .class directory > (we run them from rhn.jar); > 002 - ChannelFactoryTest: don't assume there are any existing channels; > 003 - HostBuilder: use ServerFactoryTest methods to build virtualized > hosts/guests to drop assumptions of having virtualization channels with > appropriate packages available. Since this varies some methods semantics > a bit (produced servers now have a base channel and consume > entitlements), patch tests using that class accordingly > (ServerFactoryTest and VirtualizationEntitlementsManagerTest). Also, add > a couple of methods to UserTestUtils and ServerTestUtils to ease > implementation, where appropriate. > > Comments are always welcome, I look forward in contributing similar > patches also in the future. > > Regards, > -- > Silvio Moioli > SUSE LINUX Products GmbH > Maxfeldstraße 5, 90409 Nürnberg Germany > > _______________________________________________ > Spacewalk-devel mailing list > Spacewalk-devel@redhat.com > https://www.redhat.com/mailman/listinfo/spacewalk-devel _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
