----- Original Message ----- > Hi, > > In our environment we noticed that CryptoKeyCreateActionTest was > failing. AFAIU, failure was due to the fact that the mocked request did > not have the uploaded file in it, that is, it was not a multipart request. > > In order to fix that I added some code to support multipart requests in > RhnPostMockStrutsTestCase (patch 008). Code is a little convoluted > because the API required an extra class, yet I prefer > RhnPostMockStrutsTestCase to be self-contained - other solutions are > possible if you particularly dislike the proposed implementation. This > is of course reusable in other cases where mocking an uploaded file is > needed. > > Patch 009 adds code to insert an (empty) uploaded key in > CryptoKeyCreateActionTest and this allowed the action to complete. I > also noticed that for whatever reason the "crypto.key.nokey" action > error is never issued, since CryptoKeyCreateAction extends > BaseCryptoKeyEditAction with isContentsRequired() always returning true, > so I removed that assertion as well.
Yeah, some of this is breakage due to code changing, I think. Having tests that run clean, tho, should help with keeping them that way. commit b15a5187a643decf77dad025030f82987501bd54 Thanks for contributing! G > > Regards, > -- > Silvio Moioli > SUSE LINUX Products GmbH > Maxfeldstraße 5, 90409 Nürnberg Germany > > > > _______________________________________________ > Spacewalk-devel mailing list > Spacewalk-devel@redhat.com > https://www.redhat.com/mailman/listinfo/spacewalk-devel _______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
