Ok, here's an updated patch. The $req->jar call results in undef if there are no cookies at all, which it was not checking for.
Thanks, Mike On 2/20/14 7:48 AM, "Michael Dorman" <mdor...@godaddy.com> wrote: >Fair enough. I will take a look and see if I can address that. If not, >this is really not that critical since most people are unlikely to hit >this problem, anyway. > > >On 2/20/14 5:19 AM, "Michael Mraka" <michael.mr...@redhat.com> wrote: > >>Michael Dorman wrote: >>% We recently discovered an issue where requests for any pxt page would >>% generate 500 errors. Traced it back to this submitted bug: >>% https://bugzilla.redhat.com/show_bug.cgi?id=723372 >>% >>% Apache2::Cookie->fetch dies if there is a malformed cookie sent by the >>% browser. In our case, it was a wildcard cookie, set by a different >>% site with the same domain name as our Spacewalk installation. So this >>% is not due to a bad cookie that Spacewalk itself is setting, but >>% rather the inability to deal with a malformed cookie set elsewhere. >> >>Hello Michael, >> >>I've actually already commited your patch but I have to revert it >>because it causes internal server error e.g. on /help/about.pxt. >> >> >>Regards, >> >>-- >>Michael Mráka >>Satellite Engineering, Red Hat >> >>_______________________________________________ >>Spacewalk-devel mailing list >>Spacewalk-devel@redhat.com >>https://www.redhat.com/mailman/listinfo/spacewalk-devel > > >_______________________________________________ >Spacewalk-devel mailing list >Spacewalk-devel@redhat.com >https://www.redhat.com/mailman/listinfo/spacewalk-devel
0001-Updated-cookie-parsing-code-to-handle-malformed-cook.patch
Description: 0001-Updated-cookie-parsing-code-to-handle-malformed-cook.patch
_______________________________________________ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
