I created a one line patch to round down hits so that the phrase in the
subject would become "X-Spam-Status: No, hits=4.9 required=5.0"

http://bugzilla.spamassassin.org/show_bug.cgi?id=2607

Duncan Findlay rejected the patch, saying:

>This is a FAQ. I think the general consensus is that the rounding is
confusing,
>but it's better than rounding down. People will start asking why is
SpamAssassin
>rounding down instead of rounding properly, etc. :-)
>http://wiki.spamassassin.org/w/RoundingIssues

In private mail, he said that he will be swayed by the consensus of this
list.

My view is that nothing is more obviously confusing and in-your-face
wrong than the text "X-Spam-Status: No, hits=5.0 required=5.0".  I agree
that any use of rounding will always confuse some users.  However, I
believe my proposed (1-line!) patch would fix 99% of all confusion,
since few users ever go beyond the X-Spam-Status line.  In a threshold
function such as spam status, I believe rounding down is the most
intuitive implementation.

I would appreciate hearing from folks who prefer the patch or would like
to keep the status quo (and why).  Thanks.

          - dan
--
Dan Kohn <mailto:[EMAIL PROTECTED]>
<http://www.dankohn.com/>  <tel:+1-650-327-2600>

Reply via email to