http://bugzilla.spamassassin.org/show_bug.cgi?id=3452
------- Additional Comments From [EMAIL PROTECTED] 2004-05-31 14:25 ------- I think the cast to (unsigned short) is correct. It states that we aren't going to tell the user of their error if they pass in too large a number, but the resulting behavior is still safe. size_t is portable and is meant to be used for lengths of buffers, so it is the right thing to use in these cases. I managed to fix that up on my commute in to work today instead of studying for my final exam tomorrow (sigh) along with some cascade effects of other variables that then had to be unsigned. The missing #includes are just that Windows uses a different #include for read and write, so I just have to insert that one line in two places that already have a #ifdef _WIN32 section. I also took care of some of the getopt.c stuff ... It wasn't that bad. What's left though, I'm not sure about. There's a library #include that generates a warning (thank you, Microsoft!). Maybe I should find the compiler option to exclude that warning. And then there are a number of warnings that a formal parameter (argument to a function) is never used in the body of the function. What's the C idiom for saying to not generate a warning for an unused variable? My brain is too full of languages at the moment to remember. In Lisp it is (declare (ignore variablename)). Do I have to set the switch to suppress this warning? ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
