http://bugzilla.spamassassin.org/show_bug.cgi?id=3506





------- Additional Comments From [EMAIL PROTECTED]  2004-07-27 19:13 -------
Subject: Re:  Occasionally seeing "PSPAMD" returned by spamd

On Tue, Jul 27, 2004 at 02:16:28PM -0700, [EMAIL PROTECTED] wrote:
> This patch fixes the underlying bug by declaring bytesread to be int instead 
> of
> size_t so that the test if it is <=0 works properly in all compilers.

I'd feel better if the read()/recv() calls were cast to int.  Best case
it'll fix any potential warning messages that come up when ssize_t !=
int. :)

Other than that, it all looks good to me.

+1


BTW: We should look at stealing (har-har) code from httpd and/or the
other ASF projects as appropriate.  For this issue, for instance, httpd
seems to have all their code using apr_ssize_t, which configure sets to
the appropriate size, etc, to avoid the ssize_t != int issue and all.
That'd be pretty easy to snag. :)

> It also removes all mention of ssize_t, using int instead and removing the
> conditional declarations of the ssize_t typedef. That simplifies the code
> around which this bug occurred.

Yea! :)





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Reply via email to