http://bugzilla.spamassassin.org/show_bug.cgi?id=3331





------- Additional Comments From [EMAIL PROTECTED]  2004-08-11 14:17 -------
Subject: Re:  [review] Bayes option to keep original token as db data (not key).

On Wed, Aug 11, 2004 at 01:52:00PM -0700, [EMAIL PROTECTED] wrote:
> ------- Additional Comments From [EMAIL PROTECTED]  2004-08-11 13:51 -------
> +0.9: 
> 
> why the @bindings temp copy in the @@ -1033,9 +1036,10 @@ change?
> 

The tok_touch code used to update the raw_token so I had made bindings
dynamic, then I removed that since a) tok_touch is never actually
called and it wasn't easily done in tok_touch_all and b) wasn't really
necessary.  However, I left the dynamic nature of the bindings in,
just in case there was some future use.

I could back it out if it bothers folks.


> +     (my $unpacked_token, $raw_token) = split(/\s+/, $token, 2);
> 
> split (/ /, ...) would probably be faster, if you can make that assumption.
> ditto in the @@ -1594,14 change.
> 

The backup format has \t between the elements, however I've seen some
unpack(H*) tokens with spaces at the end, so we need to check for 1 or
more whitespaces.

Michael





------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

Reply via email to