Patches item #1693447, was opened at 2007-04-03 10:39 Message generated for change (Settings changed) made by igs You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=498105&aid=1693447&group_id=61702
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Outlook Group: None Status: Open Resolution: None >Priority: 7 Private: No Submitted By: Marko von Oppen (igs) Assigned to: Nobody/Anonymous (nobody) Summary: Localization of MSG_READ_STATE Initial Comment: The values of MSG_READ_STATE 'None', 'Read', 'Unread' sometimes are used in localized and sometimes in unlocalized mode. What generally isn't a really good idea. I could not find a place where the values are represented to the user. So i think it is a good idea to not localize these values. Using the mixed mode I get error messages *** Bad new_msg_state value: 'Keine' when using the 'Spam' button. The following patch should fix this problem. ---------------------------------------------------------------------- Comment By: Marko von Oppen (igs) Date: 2008-04-02 16:13 Message: Logged In: YES user_id=260951 Originator: YES Yes it is a good idea not to localize options in the config file at all. Sure the patch works so far. I found another place in code where localized options are used in Outlook2000/filter.py. See the provided patch. File Added: lang2.patch ---------------------------------------------------------------------- Comment By: Mark Hammond (mhammond) Date: 2007-04-04 09:06 Message: Logged In: YES user_id=14198 Originator: NO OK, I think I understand what is going on. A quick question: if I trick spambayes into running the german translations, I notice the "Training" dialogs still have "mark the message as unread" in English, even though I see the .po file has provided a translation. Do you see the same? I believe a side-effect of your patch is that the INI file will now always store the english version, not the localized one - and I think that is a *good* thing - otherwise it would be a support and doc problem, but worse, would mean that as a translation gets more complete, it would break things. For example, consider the other option: FILTER_ACTION = _("Untouched"), _("Moved"), _("Copied") I believe they will be stored in the INI file as their translated version. However, none of the other translations define those messages - so the english version will be stored. If a later version of spambayes does provide a translation, their existing options would not be recognised. Could you please see if the attached patch works for you? Note there is a new string in dialog_map.py that will need to be translated (but see above - even the "mark the message as unread,..." translation isn't working for me). It includes the trick to switch spambayes languages, which I think I will leave in... File Added: lang.patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=498105&aid=1693447&group_id=61702 _______________________________________________ Spambayes-bugs mailing list Spambayes-bugs@python.org http://mail.python.org/mailman/listinfo/spambayes-bugs