Tomas,
I have now been through all the usr/src/lib/libsldap/common/*.[ch] file
with the exception of ns_standalone.c once.
I will now look through ns_confmgr.c and ns_connect.c again.
Regards
Julian
Julian Pullen wrote:
> Tomas,
>
> Here are some comments on libsldap.
>
> ns_connect.c
> ------------
> __s_api_requestServer() line 184. I think the code should be
>
> 184 if (*error != NULL) {
> 185 (void) __ns_ldap_freeError(error);
> 186 }
>
>
>
> createSession() line 2200. I would use an if (useSSL) and not "?"
> to make it more readable
>
>
> ns_common.c
> -----------
> __s_api_copy_error() Why use calloc if you going to copy
> the ns_ldap_error_t to the new allocated memory.
>
> More tomorrow.
>
> Regards
>
> Julian
>
>
>
> Tomas Heran wrote:
>> Dear All,
>>
>> we'd like to request a code review of our latest changes to LDAP naming
>> tools and infrastructure to improve connection and server management in
>> libsldap and ldap_cachemgr(1M) and to introduce "standalone" feature to
>> LDAP naming tools. This integration (when done) will deliver first set
>> of features promised by Duckwater project. We call it internally
>> Duckwater Phase 0.
>>
>> The information about the changes, RFEs and CRs and updated manual
>> pages can be found here:
>> http://www.opensolaris.org/os/project/duckwater/duckwater_phase0
>>
>> The webrev with the changes is here:
>> http://cr.opensolaris.org/~the/duckwater_phase0/
>>
>> Thanks,
>> Tomas
>
