On Wed, Sep 03, 2003 at 12:52:32AM +0200, Edouard Gomez wrote:
>
> The CVS should compile and run fine again on linux systems.
>
> <kidding>
> Should we sponsor some C language classes to francois?
> </kidding>
>
>
> 2003-09-02 22:43:43 GMT patch-5
>
> Summary:
> Unitialized variable fix.
> Revision:
> speedtouch--trunk--1.2--patch-5
>
> Francois did commit some code for freebsd that:
> 1/ broke the linux part because of a missing {
> (fixed in previous patch as well)
> 2/ broke the linux part because it was returning
> an unitialized fd variable (variable scope bug)
>
> modified files:
> src/pppoa2.c src/pppoa3.c
[...]
Thanks Edouard, this is nice ... for your information I asked *you* to
tests thoses changes *before* committing as I don't have any linux box
neither any DSL connection.
And obviously I couldn't test if I had break anything under linux.
Some people reported me this was working under FreeBSD which was the aim
of the pppoe backport. As it was working *you* told me it was fine to
commit without even looking and testing the changes.
So next time you could probably improve your communications skills and
seem a bit more involved when I ask you to test some patches that are
highly probable to break something.
Regards,
--
Francois Rogler
Liste de diffusion modem ALCATEL SpeedTouch USB
Pour se désinscrire : mailto:[EMAIL PROTECTED]
