James Rowe schrieb: > The patch attached adds a config option "exclude_file_pattern" that > is a general solution to the problem of removing files that can be > applied on top of glob inclusion. I think it makes sense because there > are definitely include/exclude patterns that hard to express with > a single fnmatch. I'd probably rather see a switch to real RegExp > for inclusion though, but I suspect that isn't likely to happen. > > The patch defaults to ".*" to exclude so-called dot files which solves > Erik's problem[1] but also sets it to a value I, as a UNIX user at > least, would expect to be the globbing default[2].
Looks good, maybe it should replace the mechanisms we have right now. > Georg, regardless of whether you like this patch just a question for > future reference: Do you prefer patches here as hg exports like this > one? Or hg patchbomb mails? Or something else entirely? Exports are fine -- patchbomb as well. Both are easy to review and apply. Georg --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sphinx-dev" group. To post to this group, send email to sphinx-dev@googlegroups.com To unsubscribe from this group, send email to sphinx-dev+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sphinx-dev?hl=en -~----------~----~----~----~------~----~------~--~---