>-----Original Message-----
>From: Baruch Siach [mailto:bar...@tkos.co.il]
>Sent: 2009年12月29日 23:00
>To: Tang, Feng
>Cc: Greg Kroah-Hartman; David Brownell; Grant Likely; spi-devel-list;
>linux-ser...@vger.kernel.org; a...@lxorguk.ukuu.org.uk; Andrew Morton
>Subject: Re: [spi-devel-general] [RFC][PATCH] serial: spi: add spi-uart driver 
>for
>Maxim 3110
>
>Hi Feng,
>
>On Tue, Dec 29, 2009 at 10:20:06PM +0800, Feng Tang wrote:
>> Here is a driver for Maxim 3110 SPI-UART device, please help to review.
>
>Is this 3110 device so significantly different from the MAX3100 driver that's
>already in the mainline kernel (drivers/serial/max3100.c), to require a whole
>new driver?

Yes, I know this question will be asked :) I developed the max3110 before 
max3100
was posted in public, so the 2 designs differs a lot from the start. I think 
this driver
has 2 good points:
1. It provides a console, which is the main reason that our platform use max3110
2. It utilizes the RX buffer of max3110 that it can reads up to 8 characters in 
one
spi_transfer, and its Tx function can transmit up to 128 chars in one 
spi_transfer
which will save much system load comparing to 1 char per spi transfer

Current max3100.c also has its advantage, like good support in CTS/RTS control,
and I think these 2 can merge in the future.

Thanks,
Feng 
>
>> It has been validated with Designware SPI controller (drivers/spi: dw_spi.c
>> & dw_spi_pci.c). It supports polling and IRQ mode, supports batch read, and
>> provides a console.
>
>baruch
>
>--
>                                                     ~. .~   Tk Open
>Systems
>=}------------------------------------------------ooO--U--Ooo------------{=
>   - bar...@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

Reply via email to