It is reasonable, looks fine to me. :-) Jason.
Uwe Kleine-König wrote: > there are no machines in-tree that still use the driver > name as device name. So save a few bytes and remove it. > > Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de> > --- > drivers/spi/spi_imx.c | 30 ++---------------------------- > 1 files changed, 2 insertions(+), 28 deletions(-) > > diff --git a/drivers/spi/spi_imx.c b/drivers/spi/spi_imx.c > index 55a38e2..9010ef0 100644 > --- a/drivers/spi/spi_imx.c > +++ b/drivers/spi/spi_imx.c > @@ -66,7 +66,6 @@ enum spi_imx_devtype { > SPI_IMX_VER_0_5, > SPI_IMX_VER_0_7, > SPI_IMX_VER_2_3, > - SPI_IMX_VER_AUTODETECT, > }; > > struct spi_imx_data; > @@ -720,9 +719,6 @@ static void spi_imx_cleanup(struct spi_device *spi) > > static struct platform_device_id spi_imx_devtype[] = { > { > - .name = DRIVER_NAME, > - .driver_data = SPI_IMX_VER_AUTODETECT, > - }, { > .name = "imx1-cspi", > .driver_data = SPI_IMX_VER_IMX1, > }, { > @@ -802,30 +798,8 @@ static int __devinit spi_imx_probe(struct > platform_device *pdev) > > init_completion(&spi_imx->xfer_done); > > - if (pdev->id_entry->driver_data == SPI_IMX_VER_AUTODETECT) { > - if (cpu_is_mx25() || cpu_is_mx35()) > - spi_imx->devtype_data = > - spi_imx_devtype_data[SPI_IMX_VER_0_7]; > - else if (cpu_is_mx25() || cpu_is_mx31() || cpu_is_mx35()) > - spi_imx->devtype_data = > - spi_imx_devtype_data[SPI_IMX_VER_0_4]; > - else if (cpu_is_mx27() || cpu_is_mx21()) > - spi_imx->devtype_data = > - spi_imx_devtype_data[SPI_IMX_VER_0_0]; > - else if (cpu_is_mx1()) > - spi_imx->devtype_data = > - spi_imx_devtype_data[SPI_IMX_VER_IMX1]; > - else > - BUG(); > - } else > - spi_imx->devtype_data = > - spi_imx_devtype_data[pdev->id_entry->driver_data]; > - > - if (!spi_imx->devtype_data.intctrl) { > - dev_err(&pdev->dev, "no support for this device compiled in\n"); > - ret = -ENODEV; > - goto out_gpio_free; > - } > + spi_imx->devtype_data = > + spi_imx_devtype_data[pdev->id_entry->driver_data]; > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > if (!res) { > ------------------------------------------------------------------------------ Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev _______________________________________________ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general