On Fri, Jul 08, 2011 at 12:58:51PM +0200, Sascha Hauer wrote:
> On Fri, Jul 08, 2011 at 04:27:30PM +0800, Shawn Guo wrote:
> > Software defined version number is not stable enough to be used
> > in device type naming scheme.  The patch changes it to use implicit
> > soc name for spi device type definition.  In this way, we can easily
> > align the naming scheme with device tree binding, which comes later.
> > 
> > Signed-off-by: Shawn Guo <[email protected]>
> > Cc: Uwe Kleine-König <[email protected]>
> > Cc: Sascha Hauer <[email protected]>
> > Cc: Grant Likely <[email protected]>
> > ---
> >  arch/arm/mach-imx/clock-imx25.c              |    7 +-
> >  arch/arm/mach-mx5/clock-mx51-mx53.c          |   11 +-
> >  arch/arm/plat-mxc/devices/platform-spi_imx.c |   12 +-
> >  drivers/spi/Kconfig                          |   15 -
> >  drivers/spi/spi-imx.c                        |  423 
> > ++++++++++++--------------
> >  5 files changed, 219 insertions(+), 249 deletions(-)
> 
> Generally this patch is too big for me to get the warm feeling that
> everything will just work. Renaming from spi_ver_xy to imx_xy is fine,
> but should be done in smaller steps and where possible not across
> subsystems.
> 
Okay, I will split the patch into small pieces to win your warm
feeling :)

> I increasingly see patches touching arch/ and drivers/ and I think
> there's a high risk of merge conflicts upstream. This will not help
> making Linus happy.
> 
Yes, I increasingly run into the situation touching arch/ and drivers/
when working on dt migration because of the device renaming.  May I
have to your suggestion on how to separate drivers/ patch from arch/
one in orthogonal way, while keeping both trees working/bisectable?

-- 
Regards,
Shawn


------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security 
threats, fraudulent activity, and more. Splunk takes this data and makes 
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2
_______________________________________________
spi-devel-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

Reply via email to