On Wed, Aug 10, 2011 at 02:20:56PM +0530, Viresh Kumar wrote: > In routine configure_dma(), if transfer->len = PAGE_SIZE, then pages is one > more > than required. While leads to one more sg getting allocated. > > This is wrong. Correct this to allocate correct number of sg. > > Signed-off-by: Viresh Kumar <viresh.ku...@st.com> > Tested-by: Linus Walleij <linus.wall...@linaro.org> > --- > drivers/spi/spi-pl022.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c > index 80116be..1c8b9ec 100644 > --- a/drivers/spi/spi-pl022.c > +++ b/drivers/spi/spi-pl022.c > @@ -1016,7 +1016,8 @@ static int configure_dma(struct pl022 *pl022) > dmaengine_slave_config(txchan, &tx_conf); > > /* Create sglists for the transfers */ > - pages = (pl022->cur_transfer->len >> PAGE_SHIFT) + 1; > + pages = ((pl022->cur_transfer->len + (1 << PAGE_SHIFT) - 1) > + >> PAGE_SHIFT);
It would be far better for this to be: pages = DIV_ROUND_UP(pl022->cur_transfer->len, PAGE_SIZE); The compiler will probably optimize it to the same code anyway. ------------------------------------------------------------------------------ uberSVN's rich system and user administration capabilities and model configuration take the hassle out of deploying and managing Subversion and the tools developers use with it. Learn more about uberSVN and get a free download at: http://p.sf.net/sfu/wandisco-dev2dev _______________________________________________ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general