On 11/9/2011 4:09 PM, Linus WALLEIJ wrote:
> From: Chris Blair <chris.bl...@stericsson.com>
> diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
> index bffad2a..2e3522d 100644
> --- a/drivers/spi/spi-pl022.c
> +++ b/drivers/spi/spi-pl022.c
> @@ -512,13 +512,6 @@ static void giveback(struct pl022 *pl022)
> msg->state = NULL;
> if (msg->complete)
> msg->complete(msg->context);
> -
> - /* disable the SPI/SSP operation */
> - writew((readw(SSP_CR1(pl022->virtbase)) &
> - (~SSP_CR1_MASK_SSE)), SSP_CR1(pl022->virtbase));
> -
We added this in an earlier patch in the same patchset. It would be better
if we can shift that patch after this one.
> - /* This message is completed, so let's turn off the clocks & power */
> - pm_runtime_put(&pl022->adev->dev);
> }
>
> /**
> @@ -1513,10 +1506,17 @@ static void pump_messages(struct work_struct *work)
> struct pl022 *pl022 =
> container_of(work, struct pl022, pump_messages);
> unsigned long flags;
> + bool was_busy = false;
>
> /* Lock queue and check for queue work */
> spin_lock_irqsave(&pl022->queue_lock, flags);
> if (list_empty(&pl022->queue) || !pl022->running) {
> + if (pl022->busy) {
> + /* nothing more to do - disable spi/ssp and power off */
> + writew((readw(SSP_CR1(pl022->virtbase)) &
> + (~SSP_CR1_MASK_SSE)), SSP_CR1(pl022->virtbase));
> + pm_runtime_put(&pl022->adev->dev);
> + }
Probably it will look better if we add a blank line here.
--
viresh
------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
