On 19/04/12 09:16 +0300, Mika Westerberg wrote: > On Wed, Apr 18, 2012 at 03:36:11PM +0300, Hannu Heikkinen wrote: > > Use devm_* functions for managing devres resources. > > > > Also use local espi_irq and remove irq variable from > > struct ep93xx_spi. > > > > Cc: [email protected] > > Cc: [email protected] > > Signed-off-by: Hannu Heikkinen <[email protected]> > > --- > > drivers/spi/spi-ep93xx.c | 36 ++++++++++-------------------------- > > 1 file changed, 10 insertions(+), 26 deletions(-) > > > > diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c > > index 6db2887..2c5fb81 100644 > > --- a/drivers/spi/spi-ep93xx.c > > +++ b/drivers/spi/spi-ep93xx.c > > @@ -114,7 +114,6 @@ struct ep93xx_spi { > > struct clk *clk; > > void __iomem *regs_base; > > unsigned long sspdr_phys; > > - int irq; > > unsigned long min_rate; > > unsigned long max_rate; > > bool running; > > @@ -1035,6 +1034,7 @@ static int __devinit ep93xx_spi_probe(struct > > platform_device *pdev) > > struct ep93xx_spi_info *info; > > struct ep93xx_spi *espi; > > struct resource *res; > > + int espi_irq; > > Since you are going to make a new version of the patch anyway, can you rename > 'espi_irq' to just plain 'irq'?
Will do. > After that you can add my > > Acked-by: Mika Westerberg <[email protected]> I will do the changes needed addressed by you and Hartley. Thanks, Hannu ------------------------------------------------------------------------------ For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
