Dear Guenter Roeck, > On Wed, Aug 01, 2012 at 11:16:15AM +0530, Shubhrajyoti Datta wrote: > > On Wed, Aug 1, 2012 at 10:59 AM, Guenter Roeck <li...@roeck-us.net> wrote: > > > On Wed, Aug 01, 2012 at 07:00:54AM +0200, Marek Vasut wrote: > > >> Dear Shawn Guo, > > >> > > >> > On Tue, Jul 31, 2012 at 08:35:59PM -0700, Guenter Roeck wrote: > > >> > > I think the call to spi_master_put() triggers the call to > > >> > > spi_master_release(). If so, kfree() would not be needed at all, > > >> > > and the documentation is wrong. > > >> > > > >> > Also those drivers calling kfree in probe. > > >> > > >> Looks like that to me ... > > > > > > Doesn't seem to be far spread, fortunately. Only spi-davinci.c, > > > spi-imx.c, and spi-omap2-mcspi.c > > > > I have a omapsdp I could patch spi-omap2-mcspi.c file thanks for the > > catch. > > For that it would be good to determine if there is a memory leak when > removing the driver (I don't see where the memory allocated with > spi_alloc_master is removed).
When the refcounting for the device reaches 0, it's deallocated. (Aka _put long enough and it'll disappear) > Thanks, > Guenter Best regards, Marek Vasut ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
