Dear Fabio Estevam,
> On Fri, Aug 3, 2012 at 10:38 AM, Thomas Petazzoni
>
> <thomas.petazz...@free-electrons.com> wrote:
> > It sounds really strange to manipulate WAIT_FOR_CMD and WAIT_FOR_IRQ
> > bits to adjust the chip select, and when reading the driver, it seemed
> > suspicious to me. After going through the datasheet, indeed those bits
> > are the appropriate one to select between the SS0, SS1 and SS2 chip
> > selects, but I find the code not really obvious. Would it be possible
> > to make it more obvious either by adding or comment or doing something
> > like:
> >
> > /* Should be put in some header file */
> > #define BM_SSP_CTRL0_SPI_CS_BITS (20)
> >
> > +static void mxs_spi_set_cs(struct mxs_spi *spi, unsigned cs)
> > +{
> > + struct mxs_ssp *ssp = &spi->ssp;
> > +
> > + writel(0x3 << BM_SSP_CTRL0_SPI_CS_BITS,
> > + ssp->base + HW_SSP_CTRL0 + STMP_OFFSET_REG_CLR);
> > + writel(cs,
> > + ssp->base + HW_SSP_CTRL0 + STMP_OFFSET_REG_SET);
> > +}
>
> I agree with Thomas.
>
> In U-boot I did the following in order to be able to select the
> different chip selects:
> http://git.denx.de/?p=u-boot.git;a=commitdiff;h=148ca64f327a89ef77e84756f5d
> 351af33e59b64
Good thing I waited with submission :)
I'll fix it in a bit and resubmit in the evening.
> Thanks,
>
> Fabio Estevam
Best regards,
Marek Vasut
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
