On Mon, 3 Dec 2012 13:38:38 -0500, Murali Karicheri <[email protected]> wrote: > This adds OF support to DaVinci SPI controller to configure platform > data through device bindings. Also replaces clk_enable() with > of clk_prepare_enable() as well as clk_disable() with > clk_disable_unprepare(). >
Hi Murali. Thanks for the patch. Comments below... > Signed-off-by: Murali Karicheri <[email protected]> > Reviewed-by : Grant Likely <[email protected]> > --- > .../devicetree/bindings/spi/spi-davinci.txt | 51 ++++++++++ > drivers/spi/spi-davinci.c | 102 > +++++++++++++++++--- > 2 files changed, 139 insertions(+), 14 deletions(-) > create mode 100644 Documentation/devicetree/bindings/spi/spi-davinci.txt > > diff --git a/Documentation/devicetree/bindings/spi/spi-davinci.txt > b/Documentation/devicetree/bindings/spi/spi-davinci.txt > new file mode 100644 > index 0000000..a2746c5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/spi-davinci.txt > @@ -0,0 +1,51 @@ > +Davinci SPI controller device bindings > + > +Required properties: > +- #address-cells: number of cells required to define a chip select > + address on the SPI bus. Should be set to 1. > +- #size-cells: should be zero. > +- compatible: > + - "ti,davinci-spi-v1" for SPI version 1.0 > + - "ti,davinci-spi-v2" for SPI version 2.0 It's better to use a specific chip name than some anonymous "v1" or "v2" (unless you can point me at some hardware documentation that actually uses those names). > +- reg: Offset and length of SPI controller register space > +- ti,davinci-spi-num-cs: Number of chip selects Simply "num-cs" is sufficient here. There is now a common binding for the number of chip select lines. Otherwise the patch and the binding look fine to me. g. ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ spi-devel-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/spi-devel-general
