On 2013-02-07 17:08, Anton Vorontsov wrote:
> On Thu, Feb 07, 2013 at 02:12:11PM +0100, Andreas Larsson wrote:
>> struct fsl_spi_reg *reg_base;
>> - int retval;
>> + int retval, desel;
>
> We don't usually place variable declarations on the same line, unless the
> variables are closely related.
>
>> u32 hw_mode;
>> struct spi_mpc8xxx_cs *cs = spi->controller_state;
>>
>> @@ -456,12 +456,45 @@ static int fsl_spi_setup(struct spi_device *spi)
>> return retval;
>> }
>>
>> + if (mpc8xxx_spi->type == TYPE_GRLIB) {
>> + if (gpio_is_valid(spi->cs_gpio)) {
>
> <- You can place the 'int desel;' here, limiting the visibility for it.
Thanks for the feedback!
I'll put that in v3. This last patch needs to wait for the other
patchset I mentioned anyway.
Cheers,
Andreas
------------------------------------------------------------------------------
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before the end March 2013
and get the hardware for free! Learn more.
http://p.sf.net/sfu/sophos-d2d-feb
_______________________________________________
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
