On Tue, 12 Feb 2013 10:46:27 +0100, Andreas Larsson <andr...@gaisler.com> wrote: > On 2013-02-11 01:23, Grant Likely wrote: > > On Tue, 29 Jan 2013 15:53:43 +0100, Andreas Larsson <andr...@gaisler.com> > > wrote: > >> Holes in the cs-gpios DT phandle list is supposed to mark that native > >> chipselects is to be used. The value returned from of_get_named_gpio_flags > >> in > >> this case is -EEXIST. By initializing cs_gpios and cs_gpio with -EEXIST, > >> this > >> and only this errno will indicate to a spi controller driver that a native > >> chipselect is to be used. > >> > >> Signed-off-by: Andreas Larsson <andr...@gaisler.com> > > > > I've left this one off for now. Take a look at the patch I posted and > > let me know if you think this one should still be applied. > > I think that of_spi_register_master should return an error when the > cs-gpios property is broken (part of patch 2) and that cs_gpios and > cs_gpio should be initialized to the same value as a hole in the plist. > > This patch does not work without 1 and 2, so I'll submit a modified > patch once "of: Create function for counting number of phandles in a > property" has stabilized. Would it have to go through the gpio branch then?
I'll put it through the DT branch since that is where I'll put the of_count_phandle patch (assuming it is ready for the 3.9 merge window). g. ------------------------------------------------------------------------------ Free Next-Gen Firewall Hardware Offer Buy your Sophos next-gen firewall before the end March 2013 and get the hardware for free! Learn more. http://p.sf.net/sfu/sophos-d2d-feb _______________________________________________ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
