Dear Trent Piepho,
> On Mon, Apr 1, 2013 at 4:30 PM, Marek Vasut <ma...@denx.de> wrote:
> >> >> -static uint32_t mxs_spi_cs_to_reg(unsigned cs)
> >> >> +static u32 mxs_spi_cs_to_reg(unsigned cs)
> >> >>
> >> >> {
> >> >>
> >> >> - uint32_t select = 0;
> >> >> + u32 select = 0;
> >>
> >> I'll make it a separate patch.
> >
> > This is completely irrelevant change, please just submit the relevant
> > patches.
>
> Kernel code should use u16, u32, etc. instead of the uint16_t,
> uint32_t types. The rest of the driver uses them. Why should this
> one function use a different type than the rest? It's ugly and
> inconsistent.
Is this documented somewhere please? I see only a mention about this in chapter
5 of Documentation/CodingStyle , section (d) . Either way, separate such
cosmetic change into another series so they're not in the way of relevant stuff.
> And really, it's just as relevant as insisting that multiline patches
> use some exact format, which checkpatch.pl doesn't complain about.
The checkpatch is not almighty tool, Documentation/CodingStyle describes how
code should be written/annotated/documented.
Best regards,
Marek Vasut
------------------------------------------------------------------------------
Own the Future-Intel(R) Level Up Game Demo Contest 2013
Rise to greatness in Intel's independent game demo contest. Compete
for recognition, cash, and the chance to get your game on Steam.
$5K grand prize plus 10 genre and skill prizes. Submit your demo
by 6/6/13. http://altfarm.mediaplex.com/ad/ck/12124-176961-30367-2
_______________________________________________
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
