On 02/05/2013 10:12, Richard Genoud : > 2013/5/2 Yang, Wenyou <wenyou.y...@atmel.com>: >> Hi, Joachim, >> >>> -----Original Message----- >>> From: Joachim Eastwood [mailto:manab...@gmail.com] >>> Sent: 2013年3月7日 20:31 >>> To: Yang, Wenyou >>> Cc: linux-arm-ker...@lists.infradead.org; grant.lik...@secretlab.ca; Ferre, >>> Nicolas; plagn...@jcrosoft.com; richard.gen...@gmail.com; Lin, JM; >>> spi-devel-general@lists.sourceforge.net; linux-ker...@vger.kernel.org >>> Subject: Re: [PATCH v6 01/16] spi/spi-atmel: fix probing failure after >>> xfer->speed_hz set >>> >>> On 7 March 2013 04:26, Wenyou Yang <wenyou.y...@atmel.com> wrote: >>>> commit: 059b8ffeee5b427949872bb6ed5db5ae0788054e >>>> cause the atmel spi probing failure. >>>> >>>> Signed-off-by: Wenyou Yang <wenyou.y...@atmel.com> >>>> Cc: spi-devel-general@lists.sourceforge.net >>>> Cc: linux-ker...@vger.kernel.org >>>> --- >>>> drivers/spi/spi-atmel.c | 6 +++--- >>>> 1 file changed, 3 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c >>>> index 656d137..1eca815 100644 >>>> --- a/drivers/spi/spi-atmel.c >>>> +++ b/drivers/spi/spi-atmel.c >>>> @@ -846,9 +846,9 @@ static int atmel_spi_transfer(struct spi_device *spi, >>> struct spi_message *msg) >>>> } >>>> } >>>> >>>> - /* FIXME implement these protocol options!! */ >>>> - if (xfer->speed_hz) { >>>> - dev_dbg(&spi->dev, "no protocol options >>> yet\n"); >>>> + if (xfer->speed_hz < spi->max_speed_hz) { >>>> + dev_dbg(&spi->dev, >>>> + "speed in transfer less than bus >>> speed\n"); >>>> return -ENOPROTOOPT; >>>> } >>> >>> I sent a similar patch to spi-devl a while ago, which Grant said he applied. >>> https://patchwork.kernel.org/patch/2165301/ >>> >>> Can't find the patch in any upstream git tree so I guess Grant hasn't >>> pushed it yet. >> This patch hasn't still applied in any upstream git tree, so Atmel spi >> master doesn't work. >> Could you help do some ping it? > > it's in linux-next: > 3d3522604a5557e80fdcab61c54bd04eaf15b525 > merged from spi-current/spi/merge
Thanks Richard, yes I can find it here: http://git.secretlab.ca/?p=linux.git;a=commit;h=3d3522604a5557e80fdcab61c54bd04eaf15b525 Grant, Mark, Can you tell us if this SPI patch will be merged upstream using one of your paths? Best regards, -- Nicolas Ferre ------------------------------------------------------------------------------ Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET Get 100% visibility into your production application - at no cost. Code-level diagnostics for performance bottlenecks with <2% overhead Download for free and get started troubleshooting in minutes. http://p.sf.net/sfu/appdyn_d2d_ap1 _______________________________________________ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general