On Wed, Apr 27, 2011 at 07:27:18AM -0400, Marc-André Lureau wrote: > Sigh.. i would prefer to avoid ASSERT, and instead use return_val_if_fail() > or so. > > That's probably why I didn't add it in the first place.
The old code would crash anyway when being passed NULL, that's why I suggested a hard ASSERT here, to crash at the same place instead of getting different failures that might be harder to diagnose later on. A g_return_val_if_fail might work, but there is no such thing in spice/ :) Christophe
pgpF2Kc7SCG0H.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
