On Mon, May 09, 2011 at 12:32:25AM +0200, Marc-André Lureau wrote: > On Sun, May 8, 2011 at 2:27 PM, Alon Levy <al...@redhat.com> wrote: > > --- > > server/red_worker.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/server/red_worker.c b/server/red_worker.c > > index b8d6a96..08096f8 100644 > > --- a/server/red_worker.c > > +++ b/server/red_worker.c > > @@ -118,7 +118,7 @@ static clockid_t clock_id; > > > > typedef unsigned long stat_time_t; > > > > -inline stat_time_t stat_now() > > +static inline stat_time_t stat_now() > > { > > struct timespec ts; > > clock_gettime(clock_id, &ts); > > I would also: > - make it (void) yeah, missed that.
> - remove the inline, the compiler should do it if it's worth then we have a ton of places to do the same change in our code base. > > but also ;) > - (eventually rename it to stat_time_now()) > - (and some day? move the stat_* definition to stat.c) > second is a good idea. First I don't mind. > > -- > > 1.7.5.1 > > > > _______________________________________________ > > Spice-devel mailing list > > Spice-devel@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/spice-devel > > > > > > -- > Marc-André Lureau _______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel