Hi,
On 10/10/2011 02:52 PM, Marc-André Lureau wrote:
Why 0.10? We are 0.7.X right now. I don't see the need to bump version number.
My bad, I assumed the next release would be a minor increment rather then a
patchlevel
increment (given the addition of usbredir + SpiceGtkSession), but I messed up
by thinking
in spice-server versions rather then in spice-gtk versions, so this should be
0.8, will fix.
Also, I wish you would have added this changes in the previous
commits, as I requested.
We discussed adding the deprecation notes on Fri 7 Oct, I pushed the initial
(and acked) patch moving the clipboard stuff to git.freedesktop.org on Thu 6
Oct.
Sorry I can do a lot of things but I don't do time travel. Also I must say I'm
a bit unhappy about to tone of this latest review. I've been spending quite a
bit
of time on this, some appreciation instead of snide remarks (*) would be nice.
Regards,
Hans
*) my interpretation, could be me, but this is how it comes over to me
On Mon, Oct 10, 2011 at 2:34 PM, Hans de Goede<[email protected]> wrote:
The SpiceGtkSession ones should be used instead.
Signed-off-by: Hans de Goede<[email protected]>
---
gtk/spice-gtk-session.c | 11 ++++-------
gtk/spice-widget.c | 11 ++++++-----
2 files changed, 10 insertions(+), 12 deletions(-)
diff --git a/gtk/spice-gtk-session.c b/gtk/spice-gtk-session.c
index d3cdd7d..e051286 100644
--- a/gtk/spice-gtk-session.c
+++ b/gtk/spice-gtk-session.c
@@ -56,13 +56,10 @@ struct _SpiceGtkSessionPrivate {
* and #SpiceSession objects. Therefor there is no spice_gtk_session_new,
* instead there is spice_gtk_session_get() which ensures this 1:1 relation.
*
- * #SpiceDisplay uses #SpiceGtkSession internally, some #SpiceDisplay
- * properties map directly to #SpiceGtkSession properties, this means that
- * changing them for one #SpiceDisplay changes them for all displays.
- *
- * Depending on your UI, you may want to not show these properties on a
- * per display basis and instead show them in a global settings menu which
- * directly uses SpiceGtkSession.
+ * Client and guest clipboards will be shared automatically if
+ * #SpiceGtkSession:auto-clipboard is set to #TRUE. Alternatively, you
+ * can send / receive clipboard data from client to guest with
+ * spice_gtk_session_copy_to_guest() / spice_gtk_session_paste_from_guest().
*/
/* ------------------------------------------------------------------ */
diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c
index 5678a81..c38da84 100644
--- a/gtk/spice-widget.c
+++ b/gtk/spice-widget.c
@@ -68,11 +68,6 @@ static inline void gdk_drawable_get_size(GdkWindow *w, gint
*ww, gint *wh)
* ungrabbed with spice_display_mouse_ungrab(), and by setting a key
* combination with spice_display_set_grab_keys().
*
- * Client and guest clipboards will be shared automatically if
- * #SpiceDisplay:auto-clipboard is set to #TRUE. Alternatively, you
- * can send clipboard data from client to guest with
- * spice_display_copy_to_guest().
-
* Finally, spice_display_get_pixbuf() will take a screenshot of the
* current display and return an #GdkPixbuf (that you can then easily
* save to disk).
@@ -1222,6 +1217,8 @@ static void spice_display_class_init(SpiceDisplayClass
*klass)
*
* When this is true the clipboard gets automatically shared between host
* and guest.
+ *
+ * Deprecated: 0.10: Use #SpiceGtkSession's auto-clipboard property instead
**/
g_object_class_install_property
(gobject_class, PROP_AUTO_CLIPBOARD,
@@ -1687,6 +1684,8 @@ void spice_display_mouse_ungrab(SpiceDisplay *display)
* @display:
*
* Copy client-side clipboard to guest clipboard.
+ *
+ * Deprecated: 0.10: Use spice_gtk_session_copy_to_guest() instead
**/
void spice_display_copy_to_guest(SpiceDisplay *display)
{
@@ -1702,6 +1701,8 @@ void spice_display_copy_to_guest(SpiceDisplay *display)
* @display:
*
* Copy guest clipboard to client-side clipboard.
+ *
+ * Deprecated: 0.10: Use spice_gtk_session_paste_from_guest() instead
**/
void spice_display_paste_from_guest(SpiceDisplay *display)
{
--
1.7.6.4
_______________________________________________
Spice-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/spice-devel
_______________________________________________
Spice-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/spice-devel
