On 01/07/2014 01:14 PM, Christophe Fergeau wrote: > Hey, > > This is a series I've had locally for a while. It moves RedsStream related > code > out of reds.c to its own file. This shaves ~1000 lines of code out of reds.c > The patch series could be split in 2 independent series, first one would be > patches 1-8 which is code movements from reds.c to redsstream.c. > Second part would be patch 9-17 were I move some RedsStream fields from being > public (exposed in a .h file) to being private (only available in > redsstream.c). > > There are still a few public fields in RedsStream after this series, but I > haven't > addressed them yet. In particular, it would be nice to hide the 'socket' > member > behind accessors so that we have a clear idea of what the rest of > spice-server code > can/cannot do with this socket. At the moment, various part of spice-server > directly call setsockopt or things like this on it.
Ack series. Just address my one comment on patch 16. > > Christophe > > _______________________________________________ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/spice-devel > _______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
