----- Original Message ----- 

> From: "Marc-André Lureau" <[email protected]>
> To: "Jonathon Jongsma" <[email protected]>
> Cc: [email protected]
> Sent: Wednesday, April 2, 2014 11:59:54 AM
> Subject: Re: [Spice-devel] [PATCH 1/2] Ensure keyboard modifiers are
> synchronized properly

> On Wed, Apr 2, 2014 at 6:57 PM, Jonathon Jongsma < [email protected] >
> wrote:

> > Indeed, it's a bit pointless at the moment. Part of the reason I made it a
> > property was because I was thinking that it might not be desirable behavior
> > in all situations, and we could add a commandline switch (to
> > spice_get_option_group()) to enable/disable that behavior. But maybe that's
> > not useful. I can hard-code it if you prefer.
> 

> I think you solved a bug, so I am not sure it needs to be configurable :)


Well, longguang.yue solved the synchronization issue (and I followed his 
example) by sending the client modifiers down to the guest whenever we detect 
that the guest has changed. You could argue that an equally valid solution 
would be so change the *client* modifiers to match the new guest value. But I 
suspect that most people prefer the approach used in this patch, so I will just 
make it non-configurable.

Jonathon
_______________________________________________
Spice-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/spice-devel

Reply via email to