> On 3 Aug 2016, at 16:20 PM, Christophe Fergeau <cferg...@redhat.com> wrote: > > On Wed, Aug 03, 2016 at 03:04:23PM +0200, Christophe Fergeau wrote: >> On Wed, Aug 03, 2016 at 03:53:27PM +0300, Dmitry Fleytman wrote: >>> >>>> On 3 Aug 2016, at 13:38 PM, Sameeh Jubran <sam...@daynix.com> wrote: >>>> >>>> >>>> >>>> On Wed, Aug 3, 2016 at 1:19 PM, Christophe Fergeau <cferg...@redhat.com >>>> <mailto:cferg...@redhat.com>> wrote: >>>> On Wed, Aug 03, 2016 at 05:25:59AM -0400, Frediano Ziglio wrote: >>>>> >>>>>> Can you please further explain regarding the licensing? which license >>>>>> should >>>>>> be used? >>>>> >>>>> These defines came from Microsoft headers or from the web like >>>>> https://msdn.microsoft.com/en-us/library/windows/hardware/ff548113(v=vs.85).aspx >>>>> >>>>> <https://msdn.microsoft.com/en-us/library/windows/hardware/ff548113(v=vs.85).aspx> >>>>> simply you can't copy from header (which have its license) and/or from web >>>>> (see >>>>> https://www.microsoft.com/en-us/legal/intellectualproperty/copyright/default.aspx >>>>> >>>>> <https://www.microsoft.com/en-us/legal/intellectualproperty/copyright/default.aspx> >>>>> ) >>>>> >>>>> Not sure about the license. Looks like Mingw headers have public domain >>>>> licensing. >>>>> For instance https://searchcode.com/codesearch/raw/11987244/ >>>>> <https://searchcode.com/codesearch/raw/11987244/> have a Microsoft >>>>> disclaimer. >>>>> >>>>> Maybe I'm too overcautious >>>> >>>> I don't think you are being too caution, either these definitions have >>>> an explicit licence compatible with the vdagent-win one, or we should >>>> not copy them this way. Why do we need to copy these definitions in >>>> vdagent-win in the first place? >>>> >>>> These definitions and structures are used in the CCD api and provided by >>>> windows, >>>> However they are absent in mingw. What are our options now? >>>> >>>> Please note that we eliminated many of the unnecessary and unused >>>> definitions from the ones we >>>> previously included in our previous patch ( >>>> https://lists.freedesktop.org/archives/spice-devel/2016-July/030796.html >>>> <https://lists.freedesktop.org/archives/spice-devel/2016-July/030796.html> >>>> ). Moreover >>>> they are now present in the cpp files. >>> >>> We dropped most of definitions from Sandy’s series and left only those >>> we really need, so there are no copy-pasted files anymore, but we cannot >>> avoid >>> using them at all because they are absent in MinGW. >>> >>> Christophe, Frediano, do you have any idea what to do in this case? >> >> If they are only needed for mingw builds, I'd start with splitting this >> in their own "Fix mingw build" patch, with an explanation why we >> duplicated header content, where the content is coming from (ie why we >> are allowed to license it the way we do), and so on. >> >> If we don't have find appropriately licensed headers covering what we >> need, then we may have to decide that CCD support is vc++ only. > > https://github.com/wine-mirror/wine/blob/master/include/wingdi.h > <https://github.com/wine-mirror/wine/blob/master/include/wingdi.h> is > LGPLv2.1 and seems to have some of the definitions we need (I did not > check all of them). I don't know if it can be used directly with mingw > and if it's a drop-in replacement for the corresponding MS header.
Great! It contains declarations we need. We will take from there. > > Christophe
_______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
