On Thu, Oct 27, 2016 at 12:41:33PM -0400, Frediano Ziglio wrote: > > > > Hey, > > > > On Wed, Oct 26, 2016 at 09:45:15AM +0100, Frediano Ziglio wrote: > > > These functions were implementing the same stuff as empty > > > messages functions provided by RedChannel so reuse them. > > > > > > The implementation seems a bit different but the result > > > is the same. Specifically: > > > - RedEmptyMsgPipeItem::msg is int while RedVerbItem::verb was > > > uint16_t however this data goes into the message type which > > > is uint16_t (a 16 bit on the network protocol); > > > > > - red_channel_client_send_empty_msg calls > > > red_channel_client_begin_send_message while red_marshall_verb > > > not. However red_marshall_verb calls are followed by either > > > > I think you are missing a "does" -> "while red_marshall_verb does not" > > > > > cursor_channel_send_item or dcc_send_item which always > > > call red_channel_client_begin_send_message. > > > > "always sent" I think. > > > > Why sent? red_channel_client_begin_send_message is a function.
Arg, dunno what I was doing when writing this email. I meant to suggest to replace "always call red_channel_client..." with "always calls red_channel_client_...". Sorry for the confusion, Christophe
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
