I’m sending the next version with updated commit message. See more answers below…
> On 8 Jun 2017, at 15:00 PM, Dmitry Fleytman <dmi...@daynix.com> wrote: > > Hi Frediano, thanks for review. > See below. > > >> On 8 Jun 2017, at 13:42 PM, Frediano Ziglio <fzig...@redhat.com >> <mailto:fzig...@redhat.com>> wrote: >> >> >> >> Hello All, >> >> This patch introduces Appveyor CI configuration file. >> >> Having this patch pushed and qxl-wddm-dod repository registered at Appveyor, >> every push or merge request will be automatically built on their servers. >> >> If you need to comment a single patch to add explanation maybe this >> additional >> explanation should be added to the commit message. > > Yes, good idea. I will add. Added. >> Build status notifications will be sent to this list >> (spice-devel@lists.freedesktop.org >> <mailto:spice-devel@lists.freedesktop.org>) >> It seems that the message arrive as html with no corresponding test, see >> https://lists.freedesktop.org/archives/spice-devel/2017-June/037963.html. >> <https://lists.freedesktop.org/archives/spice-devel/2017-June/037963.html> >> Is possible to have pure text messages instead? > > Probably yes, I will check if Appveyor supports this. Unfortunately Appveyor cannot send plain text e-mails. >> Best Regards, >> Dmitry >> >> On 8 Jun 2017, at 10:10 AM, Dmitry Fleytman <dmi...@daynix.com >> <mailto:dmi...@daynix.com>> wrote: >> >> Signed-off-by: Dmitry Fleytman <dmi...@daynix.com <mailto:dmi...@daynix.com>> >> --- >> .appveyor.yml | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> create mode 100644 .appveyor.yml >> >> diff --git a/.appveyor.yml b/.appveyor.yml >> new file mode 100644 >> index 0000000..f3f3e5c >> --- /dev/null >> +++ b/.appveyor.yml >> @@ -0,0 +1,18 @@ >> +image: Visual Studio 2015 >> + >> This cause to stick to a version of images and if image are going to be >> removed in the >> future this won't work. I use AppVeyor for another project and I know images >> are >> updated and obsolete ones are removed after a while. From my experience is >> better to >> fix the issues with the last machine version. > > Not sure I understand. What do you mean by “last machine version”? Frediano, please elaborate. >> >> +version: build-{build}-{branch} >> + >> +before_build: >> + - ren "C:\Program Files (x86)\Windows Kits\10\include\00wdf" "wdf" >> + >> +build_script: buildAll.bat >> + >> +skip_commits: >> + message: /\[ci skip\]/ >> + >> what does this? > > A nice feature borrowed from Travis-CI - If commit message includes “[ci > skip]” - CI is not run for this commit. > >> >> +notifications: >> + - provider: Email >> + to: <mailto:spice-devel@lists.freedesktop.org> >> <>spice-devel@lists.freedesktop.org >> <mailto:spice-devel@lists.freedesktop.org> >> Not strictly related to this patch, is usually a good idea to add sender >> e-mail >> to the ML. Did you do it? > > Not yet. I did not register upstream repository with Appveyor also. > Will do it after the patch is inside. >> >> + on_build_success: false >> + on_build_failure: true >> + on_build_status_changed: true >> Frediano
_______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spice-devel
