On Wed, Jul 19, 2017 at 09:42:42AM +0100, Frediano Ziglio wrote:
> -uint8_t *PngCoder::from_bitmap(const BITMAPINFO& info, const void *bits,
> long &size)
> +uint8_t *PngCoder::from_bitmap(const BITMAPINFO& bmp_info, const void *bits,
> long &size)
> {
> - // TODO not implemented
> - return NULL;
> + // this vector is here to avoid problems as libpng use setjmp/longjmpNit: I'd be more specific about the problems you are avoiding, as the goal of this comment is that someone changing this code is not going to be careful and not introduce the issues you had in mind. Looks good otherwise, Acked-by: Christophe Fergeau <[email protected]> Christophe
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/spice-devel
